Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOCAL][CI] Fix Helloworld ios jobs #45158

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[LOCAL][CI] Fix Helloworld ios jobs #45158

merged 1 commit into from
Jun 26, 2024
+43 −25

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jun 25, 2024 •
edited
Loading

Summary:

We changed the way we restore the Hermes binary, restoring it from artifacts rather than from cache.
This might have altered a little where the binary is stored and we need to update the path properly

Changelog:

[Internal] - Fix Helloworld ios jobs

Test Plan:

GHA are green

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2024
@cipolleschi cipolleschi changed the base branch from main to 0.75-stable June 25, 2024 13:03
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-helloworld-ios-on-075 branch 2 times, most recently from eae5b99 to 7a8ff08 Compare June 25, 2024 13:26
@cipolleschi
Copy link
Contributor Author

Need to update the cache key for build_hermes_macos in restore to v2-hermes-artifacts-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }}

@cipolleschi cipolleschi force-pushed the cipolleschi/fix-helloworld-ios-on-075 branch from 7a8ff08 to 5e640f6 Compare June 25, 2024 14:03
cipolleschi
cipolleschi commented Jun 25, 2024
View reviewed changes
.github/workflows/test-all.yml Outdated
@@ -206,7 +206,7 @@ jobs:
- name: Restore Cached Artifacts
uses: actions/cache/[email protected]
with:
key: v2-hermes-osx-bin-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
key: v2-hermes-artifacts-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a fix to optimize the build. I was using the wrong prefix in the previous PR.

@cipolleschi cipolleschi force-pushed the cipolleschi/fix-helloworld-ios-on-075 branch 6 times, most recently from 1677a5c to 703e987 Compare June 25, 2024 16:45
@analysis-bot
Copy link

analysis-bot commented Jun 25, 2024 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,443,803 +144,093
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,642,467 +145,560
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d3e0430
Branch: main

@cipolleschi cipolleschi marked this pull request as ready for review June 26, 2024 08:40
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-helloworld-ios-on-075 branch 2 times, most recently from c3c26d8 to 49d395b Compare June 26, 2024 08:43
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-helloworld-ios-on-075 branch from 49d395b to e7f4f05 Compare June 26, 2024 09:06
@cipolleschi cipolleschi merged commit 2a0c175 into 0.75-stable Jun 26, 2024
57 of 73 checks passed
@cipolleschi cipolleschi mentioned this pull request Jun 27, 2024
Merged
@cipolleschi cipolleschi mentioned this pull request Jul 9, 2024
Closed
@cipolleschi cipolleschi mentioned this pull request Jul 29, 2024
Merged
This was referenced Aug 15, 2024
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Sep 2, 2024
Merged
@cortinico cortinico deleted the cipolleschi/fix-helloworld-ios-on-075 branch November 4, 2024 17:54
@blakef blakef mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakef blakef blakef approved these changes

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cipolleschi @analysis-bot @blakef @cortinico @facebook-github-bot